Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659733003: Revert "Remove 'mojo_' prefix from all mojo applications." (Closed)

Created:
6 years, 2 months ago by Aaron Boodman
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Revert "Remove 'mojo_' prefix from all mojo applications." Accidentally included changes I didn't intend to. This reverts commit a10f671deab80232ec05e00924dd323fc4d13675. TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f9b1d7969b379d8d21b1164fa6766bfe91dcd157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -45 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/BUILD.gn View 4 chunks +10 lines, -4 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/apps/js/main.js View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/apptest/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/view_manager_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/content_handler_demo/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/echo/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/embedded_app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/http_server/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/keyboard/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/media_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/nesting_app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/png_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/sample_app/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/surfaces_app/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/wget/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/examples/window_manager/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/wm_flow/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
A mojo/public/VERSION View 1 chunk +1 line, -0 lines 0 comments Download
A + mojo/public/mojo.gni View 1 chunk +3 lines, -2 lines 0 comments Download
A mojo/public/tools/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A mojo/public/tools/download_shell_binary.py View 1 chunk +54 lines, -0 lines 0 comments Download
M mojo/services/clipboard/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/shell/BUILD.gn View 3 chunks +9 lines, -3 lines 0 comments Download
M mojo/shell/mojo_url_resolver.cc View 2 chunks +9 lines, -1 line 0 comments Download
M mojo/shell/mojo_url_resolver_unittest.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/tools/upload_shell_binary.py View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/find_depot_tools.py View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Aaron Boodman
6 years, 2 months ago (2014-10-23 20:35:40 UTC) #2
Aaron Boodman
6 years, 2 months ago (2014-10-23 20:36:06 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f9b1d7969b379d8d21b1164fa6766bfe91dcd157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698