Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659713003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
alicet1, chrome-apps-syd-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, msw+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, tdresser+watch_chromium.org, tfarina, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/a98fe2ba1ce798840214f12eef885c99fac02d5d Cr-Commit-Position: refs/heads/master@{#299751}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -59 lines) Patch
M ui/app_list/app_list_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/test/app_list_test_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/float_animation_curve_adapter.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/compositor/transform_animation_curve_adapter.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/latency_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M ui/events/test/mock_motion_event.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/geometry/r_tree_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/geometry/r_tree_unittest.cc View 7 chunks +15 lines, -15 lines 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/combobox.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_editing_menu.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
6 years, 2 months ago (2014-10-15 17:13:50 UTC) #2
sky
LGTM https://codereview.chromium.org/659713003/diff/1/ui/events/ozone/evdev/event_factory_evdev.cc File ui/events/ozone/evdev/event_factory_evdev.cc (right): https://codereview.chromium.org/659713003/diff/1/ui/events/ozone/evdev/event_factory_evdev.cc#newcode77 ui/events/ozone/evdev/event_factory_evdev.cc:77: scoped_ptr<EventReaderLibevdevCros> libevdev_reader = Can't the return be here?
6 years, 2 months ago (2014-10-15 19:11:39 UTC) #3
dcheng
https://codereview.chromium.org/659713003/diff/1/ui/events/ozone/evdev/event_factory_evdev.cc File ui/events/ozone/evdev/event_factory_evdev.cc (right): https://codereview.chromium.org/659713003/diff/1/ui/events/ozone/evdev/event_factory_evdev.cc#newcode77 ui/events/ozone/evdev/event_factory_evdev.cc:77: scoped_ptr<EventReaderLibevdevCros> libevdev_reader = On 2014/10/15 19:11:39, sky wrote: > ...
6 years, 2 months ago (2014-10-15 19:20:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659713003/20001
6 years, 2 months ago (2014-10-15 19:21:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-15 20:15:49 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 20:16:40 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a98fe2ba1ce798840214f12eef885c99fac02d5d
Cr-Commit-Position: refs/heads/master@{#299751}

Powered by Google App Engine
This is Rietveld 408576698