Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 659713002: Remove SynchronousMode, as it is always ForceSynchronous. (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
haraken, tasak, eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove SynchronousMode, as it is always ForceSynchronous. Since r183572, SynchronousMode is alywas ForceSynchronous, as all asynchronous parsing now uses background thread. This CL removes the enum and removes dead codes. BUG=421289 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183725

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -50 lines) Patch
M Source/core/html/parser/HTMLDocumentParser.h View 1 1 chunk +3 lines, -7 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 12 chunks +11 lines, -24 lines 0 comments Download
M Source/core/html/parser/HTMLParserScheduler.h View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kouhei (in TOK)
Refactoring. Dead code removals only.
6 years, 2 months ago (2014-10-15 04:13:10 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-15 04:14:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659713002/20001
6 years, 2 months ago (2014-10-15 04:15:15 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 07:45:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183725

Powered by Google App Engine
This is Rietveld 408576698