src/ia32/lithium-codegen-ia32.cc - Issue 6597104: Move IncrementalRecordWrite to a stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 6597104: Move IncrementalRecordWrite to a stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc

Patch Set: Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 2b1d2967bbfa1af189534b454a147240b9324737..b336d1ca307bf1a16e96c283fe73c7b1317fb501 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -1955,12 +1955,8 @@ void LCodeGen::DoStoreGlobal(LStoreGlobal* instr) {

__ mov(object, Immediate(cell_handle));

__ mov(FieldOperand(object, JSGlobalPropertyCell::kValueOffset), value);

- NearLabel done;

- __ test(value, Immediate(kSmiTagMask));

- __ j(zero, &done);

- __ IncrementalMarkingRecordWrite(object, value, scratch);

- __ bind(&done);

+ __ IncrementalMarkingRecordWrite(

+ object, value, scratch, INLINE_SMI_CHECK, DESTROY_OBJECT, DESTROY_VALUE, DESTROY_SCRATCH);

Erik Corry 2011/03/02 12:34:06 Lint.

Vyacheslav Egorov (Chromium) 2011/03/02 15:11:32 Done.

}