Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 6597104: Move IncrementalRecordWrite to a stub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/stub-cache-ia32.cc
diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc
index bf947cb59e095b682690608fd49bde5ee0f1c541..1dbaf836bb538bf54bfe1584f41c1bb6b8caf5ac 100644
--- a/src/ia32/stub-cache-ia32.cc
+++ b/src/ia32/stub-cache-ia32.cc
@@ -1498,7 +1498,8 @@ MaybeObject* CallStubCompiler::CompileArrayPushCall(Object* object,
__ bind(&with_write_barrier);
- __ IncrementalMarkingRecordWrite(ebx, ecx, edx);
+ __ IncrementalMarkingRecordWrite(
+ ebx, ecx, edx, OMIT_SMI_CHECK, PRESERVE_OBJECT, DESTROY_VALUE, PRESERVE_SCRATCH);
__ InNewSpace(ebx, ecx, equal, &exit);
@@ -2603,7 +2604,7 @@ MaybeObject* StoreStubCompiler::CompileStoreGlobal(GlobalObject* object,
__ j(zero, &done);
__ mov(ecx, eax);
- __ IncrementalMarkingRecordWrite(ebx, ecx, edx);
+ __ IncrementalMarkingRecordWrite(ebx, ecx, edx, INLINE_SMI_CHECK, DESTROY_OBJECT, DESTROY_VALUE, DESTROY_SCRATCH);
// Return the value (register eax).
__ bind(&done);

Powered by Google App Engine
This is Rietveld 408576698