Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 659693002: mac: Fix a bookmark bar unit test on OSX 10.10. (Closed)

Created:
6 years, 2 months ago by erikchen
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix a bookmark bar unit test on OSX 10.10. The test LastBookmarkResizeBehavior implicitly relied on the default system font. The system font changed from 10.9 to 10.10, breaking the test. I updated the test to use a different set of parameters on OSX 10.10+. BUG=390276 Committed: https://crrev.com/d2f7f954d4914457474df5de0abe5386fc21defa Cr-Commit-Position: refs/heads/master@{#299811}

Patch Set 1 : #

Patch Set 2 : Comments from rsesek. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 2 chunks +12 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
erikchen
rsesek: Please review.
6 years, 2 months ago (2014-10-15 20:36:30 UTC) #3
Robert Sesek
Which test does this fix, specifically? LastBookmarkResizeBehavior? If so, would it be possible to just ...
6 years, 2 months ago (2014-10-15 20:43:22 UTC) #4
erikchen
rsesek: Good suggestion, thanks! PTAL I also updated the CL description to include the name ...
6 years, 2 months ago (2014-10-15 22:36:25 UTC) #7
Robert Sesek
LGTM. Nice!
6 years, 2 months ago (2014-10-15 22:39:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659693002/80001
6 years, 2 months ago (2014-10-15 22:57:29 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 2 months ago (2014-10-16 01:46:52 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 01:47:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d2f7f954d4914457474df5de0abe5386fc21defa
Cr-Commit-Position: refs/heads/master@{#299811}

Powered by Google App Engine
This is Rietveld 408576698