cc/test/render_pass_test_utils.cc - Issue 659683002: Include mask texture size in RenderPassDrawQuad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/render_pass_test_utils.cc

Issue 659683002: Include mask texture size in RenderPassDrawQuad (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@update_mask_draw_quad_test

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/test/render_pass_test_common.cc ('K') | « cc/test/render_pass_test_common.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | cc/trees/layer_tree_host_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/test/render_pass_test_utils.cc

diff --git a/cc/test/render_pass_test_utils.cc b/cc/test/render_pass_test_utils.cc

index 1f2131635f4276a59332fc285dcc2df867b07592..71075db466093ea786fca70f7abe33e8b89cb65e 100644

--- a/cc/test/render_pass_test_utils.cc

+++ b/cc/test/render_pass_test_utils.cc

@@ -100,7 +100,8 @@ void AddRenderPassQuad(TestRenderPass* to_pass,

output_rect,

contributing_pass->id,

- gfx::RectF(),

+ gfx::Vector2dF(),

+ gfx::Size(),

FilterOperations(),

gfx::Vector2dF(),

FilterOperations());

@@ -128,7 +129,8 @@ void AddRenderPassQuad(TestRenderPass* to_pass,

output_rect,

contributing_pass->id,

mask_resource_id,

- gfx::RectF(),

+ gfx::Vector2dF(),

+ gfx::Size(),

danakj 2014/10/15 15:33:35 this would be a divide by 0 when we try to use the

enne (OOO) 2014/10/15 19:10:55 I'll make it 1, 1.

filters,

gfx::Vector2dF(),

FilterOperations());

« cc/test/render_pass_test_common.cc ('K') | « cc/test/render_pass_test_common.cc ('k') | cc/trees/layer_tree_host_impl_unittest.cc » ('j') | cc/trees/layer_tree_host_impl_unittest.cc » ('J')