telemetry: Remove PageTest support from benchmark_runner

telemetry: Remove PageTest support from benchmark_runner

R=dtu@chromium.org,tonyg@chromium.org,nednguyen@google.com
BUG=423563
Committed: https://crrev.com/1509b2228fe6514e0c0f94ff2b6e87db5b6856fd
Cr-Commit-Position: refs/heads/master@{#300182}

[ernstm, 2014-10-16 00:38:01]

PTAL

[tonyg, 2014-10-16 02:11:28]

lgtm

[nednguyen, 2014-10-16 02:25:31]

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
File tools/telemetry/telemetry/benchmark_runner.py (right):

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:107: usage = 'test_name [page_set]
[<options>]'
Remove [page_set]. I would also change the word "test" to "benchmark"

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:187: def _Tests():
s/_Tests/_Benchmarks.

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:197: def
_MatchPageSetName(input_name):
Remove this?

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:208: def
_AvailablePageSetNamesString():
Dead code.

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:217: def
_MatchTestName(input_test_name, exact_matches=True):
_MatchBenchmarkName

[ernstm, 2014-10-16 17:54:28]

I renamed all *test* variables to *benchmark*.

This file seems to have no test coverage at all, or did I miss anything?

Also, do we still need test_runner.py?

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
File tools/telemetry/telemetry/benchmark_runner.py (right):

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:187: def _Tests():
On 2014/10/16 02:25:31, nednguyen wrote:
> s/_Tests/_Benchmarks. 

Done.

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:197: def
_MatchPageSetName(input_name):
On 2014/10/16 02:25:31, nednguyen wrote:
> Remove this?

Done.

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:208: def
_AvailablePageSetNamesString():
On 2014/10/16 02:25:31, nednguyen wrote:
> Dead code.

Done.

https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
tools/telemetry/telemetry/benchmark_runner.py:217: def
_MatchTestName(input_test_name, exact_matches=True):
On 2014/10/16 02:25:31, nednguyen wrote:
> _MatchBenchmarkName

Done.

[nednguyen, 2014-10-16 20:41:22]

On 2014/10/16 17:54:28, ernstm wrote:
> I renamed all *test* variables to *benchmark*.
> 
> This file seems to have no test coverage at all, or did I miss anything?

+1 Would be great if you can add unittest for it. 

> 
> Also, do we still need test_runner.py?

Which one? I thought there was only one and I renamed it to benchmar_runner.py

> 
>
https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
> File tools/telemetry/telemetry/benchmark_runner.py (right):
> 
>
https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
> tools/telemetry/telemetry/benchmark_runner.py:187: def _Tests():
> On 2014/10/16 02:25:31, nednguyen wrote:
> > s/_Tests/_Benchmarks. 
> 
> Done.
> 
>
https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
> tools/telemetry/telemetry/benchmark_runner.py:197: def
> _MatchPageSetName(input_name):
> On 2014/10/16 02:25:31, nednguyen wrote:
> > Remove this?
> 
> Done.
> 
>
https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
> tools/telemetry/telemetry/benchmark_runner.py:208: def
> _AvailablePageSetNamesString():
> On 2014/10/16 02:25:31, nednguyen wrote:
> > Dead code.
> 
> Done.
> 
>
https://codereview.chromium.org/659673002/diff/1/tools/telemetry/telemetry/be...
> tools/telemetry/telemetry/benchmark_runner.py:217: def
> _MatchTestName(input_test_name, exact_matches=True):
> On 2014/10/16 02:25:31, nednguyen wrote:
> > _MatchBenchmarkName
> 
> Done.

[ernstm, 2014-10-16 22:16:43]

> > Also, do we still need test_runner.py?
> 
> Which one? I thought there was only one and I renamed it to benchmar_runner.py

src/tools/telemetry/telemetry/test_runner.py

[nednguyen, 2014-10-16 22:19:48]

On 2014/10/16 22:16:43, ernstm wrote:
> > > Also, do we still need test_runner.py?
> > 
> > Which one? I thought there was only one and I renamed it to
benchmar_runner.py
> 
> src/tools/telemetry/telemetry/test_runner.py

It should not exist at HEAD:
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

[ernstm, 2014-10-16 22:45:22]

On 2014/10/16 22:19:48, nednguyen wrote:
> On 2014/10/16 22:16:43, ernstm wrote:
> > > > Also, do we still need test_runner.py?
> > > 
> > > Which one? I thought there was only one and I renamed it to
> benchmar_runner.py
> > 
> > src/tools/telemetry/telemetry/test_runner.py
> 
> It should not exist at HEAD:
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

You are right. I don't know why it got stuck in my repository. It was actually
listed as an untracked file.

[dtu, 2014-10-17 19:44:07]

lgtm, this is beautiful

https://codereview.chromium.org/659673002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/benchmark_runner.py (right):

https://codereview.chromium.org/659673002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/benchmark_runner.py:8: actually running the benchmark
is in Test and PageRunner."""
Benchmark!

[ernstm, 2014-10-17 21:33:44]

https://codereview.chromium.org/659673002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/benchmark_runner.py (right):

https://codereview.chromium.org/659673002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/benchmark_runner.py:8: actually running the benchmark
is in Test and PageRunner."""
On 2014/10/17 19:44:06, dtu wrote:
> Benchmark!

Done.

[ernstm, 2014-10-17 21:37:58]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-10-17 21:39:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/659673002/40001

[commit-bot: I haz the power, 2014-10-17 22:38:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-17 22:39:49]

Patchset 3 (id:??) landed as
https://crrev.com/1509b2228fe6514e0c0f94ff2b6e87db5b6856fd
Cr-Commit-Position: refs/heads/master@{#300182}