Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 659663004: Rename extension action context menu option string "Manage" to "Manage Extensions" (Closed)

Created:
6 years, 2 months ago by shilpa.shri
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename extension action context menu option string "Manage" to "Manage Extensions" When right click on an extension browser action in the Omnibox, the contextual drop down says "Manage", which is unclear. Make the string to be more specific such as "Manage Extensions". The string's casing matches the platform; i.e. "Manage Extensions" for Mac, "Manage extensions" everywhere else. grd file changes: Modifying 1 line label and 1 line desc text each in title case and in non title case responsible for the label in: chrome/app/generated_resources.grd BUG=418691 R=rouslan@chromium.org TEST= 1) Launch chrome and install few extensions. 2) Right click an extension and observe 3) The context menu option for managing extensions should be string "Manage Extensions" on MAC, "Manage extensions" everywhere else. Committed: https://crrev.com/4b4b173612017d0e45c2be082fb6f23baa79dc2a Cr-Commit-Position: refs/heads/master@{#300516} Committed: https://crrev.com/2f4ca84a245d6eddb1ceac4d352922bd3e1ad119 Cr-Commit-Position: refs/heads/master@{#300673}

Patch Set 1 #

Patch Set 2 : "Managed Extensions" -> "Manage Extensions" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
shilpa.shri
PTAL UI team has verified string changes. (http://code.google.com/p/chromium/issues/detail?id=418691#c2) Thank you.
6 years, 2 months ago (2014-10-16 04:30:57 UTC) #1
please use gerrit instead
Please change TBR=... to R=... in the description. In general, try not to use TBR ...
6 years, 2 months ago (2014-10-20 23:03:54 UTC) #2
shilpa.shri
On 2014/10/20 23:03:54, Rouslan Solomakhin wrote: > Please change TBR=... to R=... in the description. ...
6 years, 2 months ago (2014-10-21 02:37:45 UTC) #3
please use gerrit instead
lgtm
6 years, 2 months ago (2014-10-21 16:37:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659663004/1
6 years, 2 months ago (2014-10-21 16:38:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 17:48:52 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4b4b173612017d0e45c2be082fb6f23baa79dc2a Cr-Commit-Position: refs/heads/master@{#300516}
6 years, 2 months ago (2014-10-21 17:50:28 UTC) #8
shilpa.shri
As per http://code.google.com/p/chromium/issues/detail?id=418691#c6, changing string "Managed Extensions" to "Manage Extensions" in patch set 2. CQing ...
6 years, 2 months ago (2014-10-22 11:14:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659663004/20001
6 years, 2 months ago (2014-10-22 11:15:35 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-22 13:10:47 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 13:11:37 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f4ca84a245d6eddb1ceac4d352922bd3e1ad119
Cr-Commit-Position: refs/heads/master@{#300673}

Powered by Google App Engine
This is Rietveld 408576698