Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5019)

Unified Diff: chrome/browser/content_settings/tab_specific_content_settings.h

Issue 659573003: Log mixed script shield events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Give the MixedScriptAction enum a name. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/content_settings/tab_specific_content_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index 1948126ae763fc5ec33bf00db880477894180863..9df7e6de51ce8f2188fe065fcd745ac53a4afe34 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -55,6 +55,17 @@ class TabSpecificContentSettings
static const MicrophoneCameraState CAMERA_ACCESSED = 1 << 2;
static const MicrophoneCameraState CAMERA_BLOCKED = 1 << 3;
+ // UMA statistics for the mixed content shield
+ enum MixedScriptAction {
+ MIXEDSCRIPT_DISPLAYED_SHIELD = 0,
+ MIXEDSCRIPT_DISPLAYED_BUBBLE,
+ MIXEDSCRIPT_CLICKED_ALLOW,
+ MIXEDSCRIPT_CLICKED_LEARN_MORE,
+ MIXEDSCRIPT_NUM_ACTIONS
Ilya Sherman 2014/10/16 22:20:35 FYI, the typical style is, if the enum name is Foo
lgarron 2014/10/16 22:24:30 Man, apparently I can't get nuttin' right, even if
+ };
+
+ static void RecordMixedScriptAction(MixedScriptAction action);
+
// Classes that want to be notified about site data events must implement
// this abstract class and add themselves as observer to the
// |TabSpecificContentSettings|.
« no previous file with comments | « no previous file | chrome/browser/content_settings/tab_specific_content_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698