Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/password_manager/password_store_mac.h

Issue 659563005: Standardize usage of virtual/override/final in chrome/browser/password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_mac.h
diff --git a/chrome/browser/password_manager/password_store_mac.h b/chrome/browser/password_manager/password_store_mac.h
index 0e1be3d4dd25bf56d43a90312e13c129da27c5e4..f539e360c3463b07029861cf9bac27e5fc877c47 100644
--- a/chrome/browser/password_manager/password_store_mac.h
+++ b/chrome/browser/password_manager/password_store_mac.h
@@ -37,42 +37,40 @@ class PasswordStoreMac : public password_manager::PasswordStore {
password_manager::LoginDatabase* login_db);
// Initializes |thread_|.
- virtual bool Init(
- const syncer::SyncableService::StartSyncFlare& flare,
- const std::string& sync_username) override;
+ bool Init(const syncer::SyncableService::StartSyncFlare& flare,
+ const std::string& sync_username) override;
// Stops |thread_|.
- virtual void Shutdown() override;
+ void Shutdown() override;
protected:
- virtual ~PasswordStoreMac();
+ ~PasswordStoreMac() override;
- virtual scoped_refptr<base::SingleThreadTaskRunner>
- GetBackgroundTaskRunner() override;
+ scoped_refptr<base::SingleThreadTaskRunner> GetBackgroundTaskRunner()
+ override;
private:
- virtual void ReportMetricsImpl(const std::string& sync_username) override;
- virtual password_manager::PasswordStoreChangeList AddLoginImpl(
+ void ReportMetricsImpl(const std::string& sync_username) override;
+ password_manager::PasswordStoreChangeList AddLoginImpl(
const autofill::PasswordForm& form) override;
- virtual password_manager::PasswordStoreChangeList UpdateLoginImpl(
+ password_manager::PasswordStoreChangeList UpdateLoginImpl(
const autofill::PasswordForm& form) override;
- virtual password_manager::PasswordStoreChangeList RemoveLoginImpl(
+ password_manager::PasswordStoreChangeList RemoveLoginImpl(
const autofill::PasswordForm& form) override;
- virtual password_manager::PasswordStoreChangeList
- RemoveLoginsCreatedBetweenImpl(base::Time delete_begin,
- base::Time delete_end) override;
- virtual password_manager::PasswordStoreChangeList
- RemoveLoginsSyncedBetweenImpl(base::Time delete_begin,
- base::Time delete_end) override;
- virtual void GetLoginsImpl(
- const autofill::PasswordForm& form,
- AuthorizationPromptPolicy prompt_policy,
- const ConsumerCallbackRunner& callback_runner) override;
- virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request) override;
- virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request) override;
- virtual bool FillAutofillableLogins(
+ password_manager::PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(
+ base::Time delete_begin,
+ base::Time delete_end) override;
+ password_manager::PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(
+ base::Time delete_begin,
+ base::Time delete_end) override;
+ void GetLoginsImpl(const autofill::PasswordForm& form,
+ AuthorizationPromptPolicy prompt_policy,
+ const ConsumerCallbackRunner& callback_runner) override;
+ void GetAutofillableLoginsImpl(GetLoginsRequest* request) override;
+ void GetBlacklistLoginsImpl(GetLoginsRequest* request) override;
+ bool FillAutofillableLogins(
std::vector<autofill::PasswordForm*>* forms) override;
- virtual bool FillBlacklistLogins(
+ bool FillBlacklistLogins(
std::vector<autofill::PasswordForm*>* forms) override;
// Adds the given form to the Keychain if it's something we want to store

Powered by Google App Engine
This is Rietveld 408576698