Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4185)

Unified Diff: chrome/browser/password_manager/password_generation_interactive_uitest.cc

Issue 659563005: Standardize usage of virtual/override/final in chrome/browser/password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_generation_interactive_uitest.cc
diff --git a/chrome/browser/password_manager/password_generation_interactive_uitest.cc b/chrome/browser/password_manager/password_generation_interactive_uitest.cc
index 97458e3c591cf2866467adb31abb36a1ef4a1420..76bda7d5bc3e1ed256ba9aa602236746168c866d 100644
--- a/chrome/browser/password_manager/password_generation_interactive_uitest.cc
+++ b/chrome/browser/password_manager/password_generation_interactive_uitest.cc
@@ -29,14 +29,12 @@ class TestPopupObserver : public autofill::PasswordGenerationPopupObserver {
password_visible_(false) {}
virtual ~TestPopupObserver() {}
- virtual void OnPopupShown(bool password_visible) override {
+ void OnPopupShown(bool password_visible) override {
popup_showing_ = true;
password_visible_ = password_visible;
}
- virtual void OnPopupHidden() override {
- popup_showing_ = false;
- }
+ void OnPopupHidden() override { popup_showing_ = false; }
bool popup_showing() { return popup_showing_; }
bool password_visible() { return password_visible_; }
@@ -50,7 +48,7 @@ class TestPopupObserver : public autofill::PasswordGenerationPopupObserver {
class PasswordGenerationInteractiveTest : public InProcessBrowserTest {
public:
- virtual void SetUpCommandLine(CommandLine* command_line) override {
+ void SetUpCommandLine(CommandLine* command_line) override {
// Make sure the feature is enabled.
command_line->AppendSwitch(autofill::switches::kEnablePasswordGeneration);
@@ -59,7 +57,7 @@ class PasswordGenerationInteractiveTest : public InProcessBrowserTest {
autofill::switches::kLocalHeuristicsOnlyForPasswordGeneration);
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
// Disable Autofill requesting access to AddressBook data. This will cause
// the tests to hang on Mac.
autofill::test::DisableSystemServices(browser()->profile()->GetPrefs());
@@ -74,7 +72,7 @@ class PasswordGenerationInteractiveTest : public InProcessBrowserTest {
ui_test_utils::NavigateToURL(browser(), url);
}
- virtual void TearDownOnMainThread() override {
+ void TearDownOnMainThread() override {
// Clean up UI.
ChromePasswordManagerClient* client =
ChromePasswordManagerClient::FromWebContents(GetWebContents());

Powered by Google App Engine
This is Rietveld 408576698