Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/browser/password_manager/password_store_mac_unittest.cc

Issue 659563005: Standardize usage of virtual/override/final in chrome/browser/password_manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/password_manager/password_store_mac.h" 5 #include "chrome/browser/password_manager/password_store_mac.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/files/scoped_temp_dir.h" 8 #include "base/files/scoped_temp_dir.h"
9 #include "base/memory/scoped_vector.h" 9 #include "base/memory/scoped_vector.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 LoginDatabase* login_db) 70 LoginDatabase* login_db)
71 : PasswordStoreMac(main_thread_runner, 71 : PasswordStoreMac(main_thread_runner,
72 db_thread_runner, 72 db_thread_runner,
73 keychain, 73 keychain,
74 login_db) { 74 login_db) {
75 } 75 }
76 76
77 using PasswordStoreMac::GetBackgroundTaskRunner; 77 using PasswordStoreMac::GetBackgroundTaskRunner;
78 78
79 private: 79 private:
80 virtual ~TestPasswordStoreMac() {} 80 ~TestPasswordStoreMac() override {}
81 81
82 DISALLOW_COPY_AND_ASSIGN(TestPasswordStoreMac); 82 DISALLOW_COPY_AND_ASSIGN(TestPasswordStoreMac);
83 }; 83 };
84 84
85 } // namespace 85 } // namespace
86 86
87 #pragma mark - 87 #pragma mark -
88 88
89 class PasswordStoreMacInternalsTest : public testing::Test { 89 class PasswordStoreMacInternalsTest : public testing::Test {
90 public: 90 public:
(...skipping 1345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1436 ASSERT_EQ(1u, matching_items.size()); 1436 ASSERT_EQ(1u, matching_items.size());
1437 EXPECT_EQ(ASCIIToUTF16("joe_user"), matching_items[0]->username_value); 1437 EXPECT_EQ(ASCIIToUTF16("joe_user"), matching_items[0]->username_value);
1438 matching_items.clear(); 1438 matching_items.clear();
1439 1439
1440 // Check the third-party password is still there. 1440 // Check the third-party password is still there.
1441 owned_keychain_adapter.SetFindsOnlyOwnedItems(false); 1441 owned_keychain_adapter.SetFindsOnlyOwnedItems(false);
1442 matching_items.get() = owned_keychain_adapter.PasswordsFillingForm( 1442 matching_items.get() = owned_keychain_adapter.PasswordsFillingForm(
1443 "http://some.domain.com/insecure.html", PasswordForm::SCHEME_HTML); 1443 "http://some.domain.com/insecure.html", PasswordForm::SCHEME_HTML);
1444 ASSERT_EQ(1u, matching_items.size()); 1444 ASSERT_EQ(1u, matching_items.size());
1445 } 1445 }
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.h ('k') | chrome/browser/password_manager/save_password_infobar_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698