Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 659563004: Chromecast: extracts Linux window creation code to a common place. (Closed)

Created:
6 years, 2 months ago by gunsch
Modified:
6 years, 2 months ago
Reviewers:
lcwu1, GusFernandez
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: extracts Linux window creation code to a common place. R=lcwu@chromium.org,gusfernandez@chromium.org BUG=None Committed: https://crrev.com/f898f99146b7cde544c9c10d7cbe9861a6c71bc5 Cr-Commit-Position: refs/heads/master@{#300360}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase, delete aura instance in ~CastBrowserProcess #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -74 lines) Patch
M chromecast/browser/cast_browser_process.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
A chromecast/browser/cast_content_window.h View 1 chunk +48 lines, -0 lines 0 comments Download
A chromecast/browser/cast_content_window.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M chromecast/browser/service/cast_service_simple.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chromecast/browser/service/cast_service_simple.cc View 4 chunks +7 lines, -69 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
6 years, 2 months ago (2014-10-14 20:45:27 UTC) #1
lcwu1
https://codereview.chromium.org/659563004/diff/1/chromecast/browser/service/cast_service_simple.cc File chromecast/browser/service/cast_service_simple.cc (left): https://codereview.chromium.org/659563004/diff/1/chromecast/browser/service/cast_service_simple.cc#oldcode132 chromecast/browser/service/cast_service_simple.cc:132: aura::Env::DeleteInstance(); Deleting the aura Env instance should now happen ...
6 years, 2 months ago (2014-10-15 20:00:00 UTC) #2
gunsch
https://codereview.chromium.org/659563004/diff/1/chromecast/browser/service/cast_service_simple.cc File chromecast/browser/service/cast_service_simple.cc (left): https://codereview.chromium.org/659563004/diff/1/chromecast/browser/service/cast_service_simple.cc#oldcode132 chromecast/browser/service/cast_service_simple.cc:132: aura::Env::DeleteInstance(); On 2014/10/15 20:00:00, lcwu1 wrote: > Deleting the ...
6 years, 2 months ago (2014-10-20 21:40:19 UTC) #3
lcwu1
lgtm
6 years, 2 months ago (2014-10-20 21:51:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659563004/20001
6 years, 2 months ago (2014-10-20 21:54:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 22:40:06 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 22:40:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f898f99146b7cde544c9c10d7cbe9861a6c71bc5
Cr-Commit-Position: refs/heads/master@{#300360}

Powered by Google App Engine
This is Rietveld 408576698