Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: cc/resources/zero_copy_raster_worker_pool.cc

Issue 659563002: cc: Replace RasterBuffer::Acquire/ReleaseCanvas with Playback function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add temporary size variable Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/tile_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/zero_copy_raster_worker_pool.cc
diff --git a/cc/resources/zero_copy_raster_worker_pool.cc b/cc/resources/zero_copy_raster_worker_pool.cc
index 1e920903bc26804422ab94c9554ef4765bd4b6a4..c9533f8092bc9aa00af609eaeca9b9acceae11a5 100644
--- a/cc/resources/zero_copy_raster_worker_pool.cc
+++ b/cc/resources/zero_copy_raster_worker_pool.cc
@@ -12,7 +12,6 @@
#include "cc/debug/traced_value.h"
#include "cc/resources/raster_buffer.h"
#include "cc/resources/resource.h"
-#include "third_party/skia/include/utils/SkNullCanvas.h"
#include "ui/gfx/gpu_memory_buffer.h"
namespace cc {
@@ -22,39 +21,31 @@ class RasterBufferImpl : public RasterBuffer {
public:
RasterBufferImpl(ResourceProvider* resource_provider,
const Resource* resource)
- : lock_(resource_provider, resource->id()),
- resource_(resource),
- buffer_(NULL) {}
+ : lock_(resource_provider, resource->id()), resource_(resource) {}
// Overridden from RasterBuffer:
- virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() override {
- gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_.gpu_memory_buffer();
- if (!gpu_memory_buffer)
- return skia::AdoptRef(SkCreateNullCanvas());
-
- buffer_ = gpu_memory_buffer->Map();
- RasterWorkerPool::AcquireBitmapForBuffer(&bitmap_,
- buffer_,
- resource_->format(),
- resource_->size(),
- gpu_memory_buffer->GetStride());
- return skia::AdoptRef(new SkCanvas(bitmap_));
- }
- virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) override {
+ virtual void Playback(const PicturePileImpl* picture_pile,
+ const gfx::Rect& rect,
+ float scale,
+ RenderingStatsInstrumentation* stats) override {
gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_.gpu_memory_buffer();
if (!gpu_memory_buffer)
return;
- RasterWorkerPool::ReleaseBitmapForBuffer(
- &bitmap_, buffer_, resource_->format());
+ RasterWorkerPool::PlaybackToMemory(gpu_memory_buffer->Map(),
+ resource_->format(),
+ resource_->size(),
+ gpu_memory_buffer->GetStride(),
+ picture_pile,
+ rect,
+ scale,
+ stats);
gpu_memory_buffer->Unmap();
}
private:
ResourceProvider::ScopedWriteLockGpuMemoryBuffer lock_;
const Resource* resource_;
- void* buffer_;
- SkBitmap bitmap_;
DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
};
« no previous file with comments | « cc/resources/tile_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698