Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4511)

Unified Diff: cc/resources/one_copy_raster_worker_pool.cc

Issue 659563002: cc: Replace RasterBuffer::Acquire/ReleaseCanvas with Playback function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add temporary size variable Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/gpu_raster_worker_pool.cc ('k') | cc/resources/pixel_buffer_raster_worker_pool.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/one_copy_raster_worker_pool.cc
diff --git a/cc/resources/one_copy_raster_worker_pool.cc b/cc/resources/one_copy_raster_worker_pool.cc
index 5b8a5c16ea7dd47fce9aa264aef44bc80f1a33b6..a297451e076382c37a7961fae7d1c0335fc76d95 100644
--- a/cc/resources/one_copy_raster_worker_pool.cc
+++ b/cc/resources/one_copy_raster_worker_pool.cc
@@ -14,7 +14,6 @@
#include "cc/resources/resource_pool.h"
#include "cc/resources/scoped_resource.h"
#include "gpu/command_buffer/client/gles2_interface.h"
-#include "third_party/skia/include/utils/SkNullCanvas.h"
#include "ui/gfx/gpu_memory_buffer.h"
namespace cc {
@@ -31,8 +30,7 @@ class RasterBufferImpl : public RasterBuffer {
raster_resource_(resource_pool->AcquireResource(resource->size())),
lock_(new ResourceProvider::ScopedWriteLockGpuMemoryBuffer(
resource_provider_,
- raster_resource_->id())),
- buffer_(NULL) {}
+ raster_resource_->id())) {}
virtual ~RasterBufferImpl() {
// First unlock raster resource.
@@ -47,26 +45,22 @@ class RasterBufferImpl : public RasterBuffer {
}
// Overridden from RasterBuffer:
- virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() override {
- gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_->gpu_memory_buffer();
- if (!gpu_memory_buffer)
- return skia::AdoptRef(SkCreateNullCanvas());
-
- buffer_ = gpu_memory_buffer->Map();
- RasterWorkerPool::AcquireBitmapForBuffer(&bitmap_,
- buffer_,
- resource_->format(),
- resource_->size(),
- gpu_memory_buffer->GetStride());
- return skia::AdoptRef(new SkCanvas(bitmap_));
- }
- virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) override {
+ virtual void Playback(const PicturePileImpl* picture_pile,
+ const gfx::Rect& rect,
+ float scale,
+ RenderingStatsInstrumentation* stats) override {
gfx::GpuMemoryBuffer* gpu_memory_buffer = lock_->gpu_memory_buffer();
if (!gpu_memory_buffer)
return;
- RasterWorkerPool::ReleaseBitmapForBuffer(
- &bitmap_, buffer_, resource_->format());
+ RasterWorkerPool::PlaybackToMemory(gpu_memory_buffer->Map(),
+ resource_->format(),
+ resource_->size(),
+ gpu_memory_buffer->GetStride(),
+ picture_pile,
+ rect,
+ scale,
+ stats);
gpu_memory_buffer->Unmap();
}
@@ -76,8 +70,6 @@ class RasterBufferImpl : public RasterBuffer {
const Resource* resource_;
scoped_ptr<ScopedResource> raster_resource_;
scoped_ptr<ResourceProvider::ScopedWriteLockGpuMemoryBuffer> lock_;
- void* buffer_;
- SkBitmap bitmap_;
DISALLOW_COPY_AND_ASSIGN(RasterBufferImpl);
};
« no previous file with comments | « cc/resources/gpu_raster_worker_pool.cc ('k') | cc/resources/pixel_buffer_raster_worker_pool.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698