Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9040)

Unified Diff: cc/resources/raster_buffer.h

Issue 659563002: cc: Replace RasterBuffer::Acquire/ReleaseCanvas with Playback function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/raster_buffer.h
diff --git a/cc/resources/raster_buffer.h b/cc/resources/raster_buffer.h
index d148b72dfe5a913e805b46fe27e8f9166ff0420a..df7ea5fe20bc1f70298a068dc678382903822ced 100644
--- a/cc/resources/raster_buffer.h
+++ b/cc/resources/raster_buffer.h
@@ -6,19 +6,21 @@
#define CC_RESOURCES_RASTER_BUFFER_H_
#include "cc/base/cc_export.h"
-#include "skia/ext/refptr.h"
-
-class SkCanvas;
+#include "ui/gfx/geometry/rect.h"
namespace cc {
+class PicturePileImpl;
+class RenderingStatsInstrumentation;
class CC_EXPORT RasterBuffer {
public:
RasterBuffer();
virtual ~RasterBuffer();
- virtual skia::RefPtr<SkCanvas> AcquireSkCanvas() = 0;
- virtual void ReleaseSkCanvas(const skia::RefPtr<SkCanvas>& canvas) = 0;
+ virtual void Playback(const PicturePileImpl* picture_pile,
vmpstr 2014/10/15 00:09:30 I'm not really a fan of this leaking to RasterBuff
reveman 2014/10/15 01:24:06 Yes, I'm a bit annoyed by this too but the cleanup
+ const gfx::Rect& rect,
+ float scale,
+ RenderingStatsInstrumentation* stats) = 0;
};
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698