build/android/pylib/device/adb_wrapper_test.py - Issue 659533002: New run shell implementation for DeviceUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/device/adb_wrapper_test.py

Issue 659533002: New run shell implementation for DeviceUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed nit, and TODO to make cmd_helper_test run on bots Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/device/adb_wrapper_test.py

diff --git a/build/android/pylib/device/adb_wrapper_test.py b/build/android/pylib/device/adb_wrapper_test.py

index 08b7fcc99e9bb1b580c1b72736b81db7550800e9..208196afe553da3ed227a5d1669c2735c57039a2 100644

--- a/build/android/pylib/device/adb_wrapper_test.py

+++ b/build/android/pylib/device/adb_wrapper_test.py

@@ -41,8 +41,8 @@ class TestAdbWrapper(unittest.TestCase):

self.assertEqual(output.strip(), 'test')

output = self._adb.Shell('echo test')

self.assertEqual(output.strip(), 'test')

- self.assertRaises(device_errors.AdbCommandFailedError, self._adb.Shell,

- 'echo test', expect_rc=1)

+ self.assertRaises(device_errors.AdbShellCommandFailedError,

+ self._adb.Shell, 'echo test', expect_rc=1)

def testPushPull(self):

path = self._MakeTempFile('foo')