Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 65953002: [Autofill] Rename autofill_common_test -> autofill_test_utils (Closed)

Created:
7 years, 1 month ago by Ilya Sherman
Modified:
7 years, 1 month ago
Reviewers:
Nico, blundell
CC:
chromium-reviews, tim+watch_chromium.org, jam, benquan, haitaol+watch_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, markusheintz_, rsimha+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Autofill] Rename autofill_common_test -> autofill_test_utils BUG=315492 TEST=none R=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -350 lines) Patch
M chrome/browser/autofill/autofill_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/autofill_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/content/browser/autofill_driver_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/wallet_address_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autocomplete_history_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/autofill/core/browser/autofill_common_test.h View 1 chunk +0 lines, -101 lines 0 comments Download
D components/autofill/core/browser/autofill_common_test.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_merge_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/autofill/core/browser/autofill_test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/autofill/core/browser/autofill_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
7 years, 1 month ago (2013-11-08 00:12:05 UTC) #1
Ilya Sherman
Nico, seeking stamp for the changes in chrome/ layer (feel free to skip over chrome/browser/autofill ...
7 years, 1 month ago (2013-11-08 00:14:40 UTC) #2
Nico
lgtm
7 years, 1 month ago (2013-11-08 00:16:37 UTC) #3
blundell
LGTM, thanks!
7 years, 1 month ago (2013-11-08 16:59:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/65953002/1
7 years, 1 month ago (2013-11-09 03:39:56 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-09 18:07:45 UTC) #6
Message was sent while issue was closed. 
Change committed as 234134

Powered by Google App Engine
This is Rietveld 408576698