Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: components/nacl_nonsfi.gyp

Issue 659513004: Non-SFI Mode: Build base/ library by PNaCL toolchain for nacl_helper_nonsfi. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/posix/unix_domain_socket_linux.cc ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl_nonsfi.gyp
diff --git a/components/nacl_nonsfi.gyp b/components/nacl_nonsfi.gyp
index 8df21e28bd221432eabb02fc564ee301236bfda5..3bd4a13b777ce1f74f5afdd5e7c8bea93df39405 100644
--- a/components/nacl_nonsfi.gyp
+++ b/components/nacl_nonsfi.gyp
@@ -40,20 +40,17 @@
'conditions': [
['target_arch=="ia32" or target_arch=="x64"', {
'extra_deps_newlib32_nonsfi': [
+ '>(tc_lib_dir_nonsfi_helper32)/libbase_nacl_nonsfi.a',
'>(tc_lib_dir_nonsfi_helper32)/libevent_nacl_nonsfi.a',
],
}],
],
},
'dependencies': [
+ '<(DEPTH)/base/base_nacl.gyp:base_nacl_nonsfi',
'<(DEPTH)/native_client/src/nonsfi/irt/irt.gyp:nacl_sys_private',
'<(DEPTH)/native_client/src/untrusted/nacl/nacl.gyp:nacl_lib_newlib',
'<(DEPTH)/native_client/tools.gyp:prep_toolchain',
-
- # TODO(hidehiko): Remove this when we introduce base/.
- # This dependency is introduced to make sure the library is
- # actually built successfully.
- '<(DEPTH)/third_party/libevent/libevent_nacl_nonsfi.gyp:event_nacl_nonsfi',
],
},
# TODO(hidehiko): Add Non-SFI version of nacl_loader_unittests.
« base/posix/unix_domain_socket_linux.cc ('K') | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698