Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659503003: Add analytics to sheriff-o-matic. (Closed)

Created:
6 years, 2 months ago by ghost stip (do not use)
Modified:
6 years, 2 months ago
Reviewers:
ojan
CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
A Tools/GardeningServer/lib/analytics.html View 1 1 chunk +22 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-sheriff-o-matic.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ghost stip (do not use)
ptal
6 years, 2 months ago (2014-10-15 02:30:42 UTC) #1
ojan
lgtm https://codereview.chromium.org/659503003/diff/1/Tools/GardeningServer/lib/analytics.html File Tools/GardeningServer/lib/analytics.html (right): https://codereview.chromium.org/659503003/diff/1/Tools/GardeningServer/lib/analytics.html#newcode9 Tools/GardeningServer/lib/analytics.html:9: (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ Maybe add a comment about where this ...
6 years, 2 months ago (2014-10-15 03:44:49 UTC) #2
ghost stip (do not use)
https://codereview.chromium.org/659503003/diff/1/Tools/GardeningServer/lib/analytics.html File Tools/GardeningServer/lib/analytics.html (right): https://codereview.chromium.org/659503003/diff/1/Tools/GardeningServer/lib/analytics.html#newcode9 Tools/GardeningServer/lib/analytics.html:9: (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){ On 2014/10/15 03:44:49, ojan-only-code-yellow-reviews wrote: > Maybe add ...
6 years, 2 months ago (2014-10-15 19:02:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659503003/20001
6 years, 2 months ago (2014-10-15 19:03:44 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 21:19:07 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183764

Powered by Google App Engine
This is Rietveld 408576698