Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 659493007: Set AppActivityProxy window name for better Ctrl+Shift+Alt+W output (Closed)

Created:
6 years, 1 month ago by hashimoto
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@activitystate
Project:
chromium
Visibility:
Public.

Description

Set AppActivityProxy window name for better Ctrl+Shift+Alt+W output To call GetWindow(), make overridden methods of AppActivityProxy public. (this should be OK as AppActivity is doing the same thing and these methods become public with static_cast<Activity*>). BUG=None Committed: https://crrev.com/448146f6973ea1850e8beccf9c921c97c48b8a1b Cr-Commit-Position: refs/heads/master@{#302028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M athena/content/app_activity_proxy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/content/app_activity_proxy.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/content/app_activity_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
6 years, 1 month ago (2014-10-29 06:01:58 UTC) #2
Mr4D (OOO till 08-26)
lgtm
6 years, 1 month ago (2014-10-29 14:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659493007/1
6 years, 1 month ago (2014-10-30 03:28:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 04:08:38 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 04:09:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/448146f6973ea1850e8beccf9c921c97c48b8a1b
Cr-Commit-Position: refs/heads/master@{#302028}

Powered by Google App Engine
This is Rietveld 408576698