Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659493005: Don't add subpixel accumulations for squashed layers when invalidating them. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Don't add subpixel accumulations for squashed layers when invalidating them. Also clean up the code related to squashing in CompositedLayerMapping a little bit. BUG=417994 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183703

Patch Set 1 #

Patch Set 2 : Fixed #

Patch Set 3 : Fixed #

Patch Set 4 : Fixed. #

Patch Set 5 : Final version. #

Patch Set 6 : Remove unnecessary file. #

Patch Set 7 : Fixed. #

Total comments: 8

Patch Set 8 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
A LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html View 1 2 3 4 5 6 7 1 chunk +17 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer-expected.txt View 1 2 3 4 5 6 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderLayerModelObject.cpp View 1 2 3 4 5 6 7 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chrishtr
https://codereview.chromium.org/659493005/diff/120001/LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer-expected.txt File LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer-expected.txt (right): https://codereview.chromium.org/659493005/diff/120001/LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer-expected.txt#newcode24 LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer-expected.txt:24: [50, 50, 200, 200] Before this fix it was ...
6 years, 2 months ago (2014-10-14 21:43:13 UTC) #2
leviw_travelin_and_unemployed
A few nits, but LGTM. https://codereview.chromium.org/659493005/diff/120001/LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html File LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html (right): https://codereview.chromium.org/659493005/diff/120001/LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html#newcode5 LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html:5: </video> --> Left this ...
6 years, 2 months ago (2014-10-14 21:49:09 UTC) #3
chrishtr
https://codereview.chromium.org/659493005/diff/120001/LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html File LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html (right): https://codereview.chromium.org/659493005/diff/120001/LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html#newcode5 LayoutTests/compositing/squashing/invalidation-for-subpixel-offset-of-squashed-layer.html:5: </video> --> On 2014/10/14 21:49:09, leviw wrote: > Left ...
6 years, 2 months ago (2014-10-14 21:54:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659493005/100002
6 years, 2 months ago (2014-10-14 21:56:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 22:58:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #8 (id:100002) as 183703

Powered by Google App Engine
This is Rietveld 408576698