chrome/browser/android/tab_android.h - Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.h

Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete some more template files Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc ('K') | « chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc ('k') | chrome/browser/android/tab_load_status.h » ('j') | chrome/browser/sync/profile_sync_service_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/tab_android.h

diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h

index 308fd6f2408607a47a8ad44bb845c84b71048155..52f97e26a5f4d261a5c54fe18c7a1e01defcd606 100644

--- a/chrome/browser/android/tab_android.h

+++ b/chrome/browser/android/tab_android.h

@@ -46,10 +46,13 @@ class TabAndroid : public CoreTabHelperDelegate,

public SearchTabHelperDelegate,

public content::NotificationObserver {

public:

+ // A Java counterpart will be generated for this enum.

+ // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser

enum TabLoadStatus {

-#define DEFINE_TAB_LOAD_STATUS(name, value) name = value,

-#include "chrome/browser/android/tab_load_status.h"

-#undef DEFINE_TAB_LOAD_STATUS

+ PAGE_LOAD_FAILED = 0,

+ DEFAULT_PAGE_LOAD = 1,

+ PARTIAL_PRERENDERED_PAGE_LOAD = 2,

+ FULL_PRERENDERED_PAGE_LOAD = 3,

};

// Convenience method to retrieve the Tab associated with the passed