build/config/android/rules.gni - Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/rules.gni

Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete some more template files Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/rules.gni

diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni

index 0c9dbf221110b302beff2126a42e432fea570621..0f8f565043cae5bb8f7b51ee480ed358a7b9698d 100644

--- a/build/config/android/rules.gni

+++ b/build/config/android/rules.gni

@@ -186,6 +186,9 @@ template("generate_jar_jni") {

# Declare a target for c-preprocessor-generated java files

+# NOTE: For generating Java conterparts to enums prefer using the java_cpp_enum

+# rule instead.

# This target generates java files using the host C pre-processor. Each file in

# sources will be compiled using the C pre-processor. If include_path is

# specified, it will be passed (with --I) to the pre-processor.

« base/memory/memory_pressure_listener.h ('K') | « build/android/java_cpp_template.gypi ('k') | build/get_landmines.py » ('j') | build/get_landmines.py » ('J')