chrome/browser/android/activity_type_id_list.h - Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/activity_type_id_list.h

Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete some more template files Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/BUILD.gn ('K') | « chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java ('k') | chrome/browser/android/activity_type_ids.h » ('j') | chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/activity_type_id_list.h

diff --git a/chrome/browser/android/activity_type_id_list.h b/chrome/browser/android/activity_type_id_list.h

deleted file mode 100644

index 805e15e39154185cfdf971ec513f3d69274b922a..0000000000000000000000000000000000000000

--- a/chrome/browser/android/activity_type_id_list.h

+++ /dev/null

@@ -1,19 +0,0 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

-// Intentionally no include guards because this file is meant to be included

-// inside a macro to generate enum values.

-// Define Activities we are interested in tracking. IDs are assigned

Yaron 2014/10/15 02:36:49 This comment was lost

Yaron 2014/10/15 18:31:57 bump

mkosiba (inactive) 2014/10/16 12:45:07 Not sure how I missed these comments, thanks for b

-// consecutively, from NONE to MAX_VALUE. Activities that are not explicitly

-// defined are all assigned the UNKNOWN value. When adding new ones, make sure

-// to append them after current Activities and to update the |AndroidActivityId|

-// enum in |histograms.xml|.

-DEFINE_ACTIVITY_ID(NONE, 0)

-DEFINE_ACTIVITY_ID(UNKNOWN, 1)

-DEFINE_ACTIVITY_ID(MAIN, 2)

-DEFINE_ACTIVITY_ID(PREFERENCES, 3)

-DEFINE_ACTIVITY_ID(WEBAPPACTIVITY, 4)

-DEFINE_ACTIVITY_ID(FULLSCREENACTIVITY, 5)

-DEFINE_ACTIVITY_ID(MAX_VALUE, 6)