Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3037)

Unified Diff: build/android/java_cpp_template.gypi

Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/java_cpp_enum_tests.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/java_cpp_template.gypi
diff --git a/build/android/java_cpp_template.gypi b/build/android/java_cpp_template.gypi
index 036f32cf5af67e805edf7c710bdfd4b178bad3e1..3296659240b57b7f2711ac7d204622988b7de0c7 100644
--- a/build/android/java_cpp_template.gypi
+++ b/build/android/java_cpp_template.gypi
@@ -6,6 +6,9 @@
# to generate Java source files from templates that are processed
# through the host C pre-processor.
#
+# NOTE: For generating Java conterparts to enums prefer using the java_cpp_enum
+# rule instead.
+#
# To use this, create a gyp target with the following form:
# {
# 'target_name': 'android_net_java_constants',
@@ -15,7 +18,7 @@
# ],
# 'variables': {
# 'package_name': 'org/chromium/net',
-# 'template_deps': ['net/base/certificate_mime_type_list.h'],
+# 'template_deps': ['base/net_error_list.h'],
# },
# 'includes': [ '../build/android/java_cpp_template.gypi' ],
# },
« no previous file with comments | « build/android/gyp/java_cpp_enum_tests.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698