Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: components/cronet/android/chromium_url_request.h

Issue 659493003: Final step of the java_cpp_template -> java_cpp_enum migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address feedback + fix aosp Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_ 5 #ifndef COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_
6 #define COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_ 6 #define COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 namespace cronet { 10 namespace cronet {
11 11
12 // Define request priority values like REQUEST_PRIORITY_IDLE in a 12 // Define request priority values like REQUEST_PRIORITY_IDLE in a
13 // way that ensures they're always the same than their Java counterpart. 13 // way that ensures they're always the same than their Java counterpart.
14 enum UrlRequestPriority { 14 enum UrlRequestPriority {
15 #define DEFINE_REQUEST_PRIORITY(x, y) REQUEST_PRIORITY_##x = y, 15 REQUEST_PRIORITY_IDLE = 0,
16 #include "components/cronet/android/chromium_url_request_priority_list.h" 16 REQUEST_PRIORITY_LOWEST = 1,
17 #undef DEFINE_REQUEST_PRIORITY 17 REQUEST_PRIORITY_LOW = 2,
18 REQUEST_PRIORITY_MEDIUM = 3,
19 REQUEST_PRIORITY_HIGHEST = 4,
18 }; 20 };
19 21
20 // Define request priority values like REQUEST_ERROR_SUCCESS in a 22 // Define request priority values like REQUEST_ERROR_SUCCESS in a
21 // way that ensures they're always the same than their Java counterpart. 23 // way that ensures they're always the same than their Java counterpart.
22 enum UrlRequestError { 24 enum UrlRequestError {
mmenke 2014/10/15 13:33:11 You presumably need to update the java files that
mkosiba (inactive) 2014/10/16 12:45:07 I'll just instruct the generator to generate the e
23 #define DEFINE_REQUEST_ERROR(x, y) REQUEST_ERROR_##x = y, 25 REQUEST_ERROR_SUCCESS = 1,
mmenke 2014/10/15 13:33:12 BUG: Success should be 0.
mkosiba (inactive) 2014/10/16 12:45:07 Fixed. Didn't realize I wasn't compiling cronet,
24 #include "components/cronet/android/chromium_url_request_error_list.h" 26 REQUEST_ERROR_UNKNOWN = 1,
25 #undef DEFINE_REQUEST_ERROR 27 REQUEST_ERROR_MALFORMED_URL = 2,
28 REQUEST_ERROR_CONNECTION_TIMED_OUT = 3,
29 REQUEST_ERROR_UNKNOWN_HOST = 4,
26 }; 30 };
27 31
28 bool ChromiumUrlRequestRegisterJni(JNIEnv* env); 32 bool ChromiumUrlRequestRegisterJni(JNIEnv* env);
29 33
30 } // namespace cronet 34 } // namespace cronet
31 35
32 #endif // COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_ 36 #endif // COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698