Final step of the java_cpp_template -> java_cpp_enum migration.

components/cronet/android/chromium_url_request.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_
 #define COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_
 
 #include <jni.h>
 
 namespace cronet {
 
 // Define request priority values like REQUEST_PRIORITY_IDLE in a
 // way that ensures they're always the same than their Java counterpart.
 enum UrlRequestPriority {

[Yaron, 2014/10/15 02:36:49]

Doesn't this need a directive to call it ChromiumUrlRequestPriority? 
(ChromiumUrlRequest.java depends on this type)

[Yaron, 2014/10/15 18:31:57]

bump

[mkosiba (inactive), 2014/10/16 12:45:07]

yup. Completely missed this as cronet does not build with my build config by
default (and it doesn't look like it builds on any of the trybots either)?. I
added the missing directives.

-#define DEFINE_REQUEST_PRIORITY(x, y) REQUEST_PRIORITY_##x = y,
-#include "components/cronet/android/chromium_url_request_priority_list.h"
-#undef DEFINE_REQUEST_PRIORITY
+  REQUEST_PRIORITY_IDLE = 0,
+  REQUEST_PRIORITY_LOWEST = 1,
+  REQUEST_PRIORITY_LOW = 2,
+  REQUEST_PRIORITY_MEDIUM = 3,
+  REQUEST_PRIORITY_HIGHEST = 4,
 };
 
 // Define request priority values like REQUEST_ERROR_SUCCESS in a
 // way that ensures they're always the same than their Java counterpart.
 enum UrlRequestError {

[Yaron, 2014/10/15 02:36:49]

same here

-#define DEFINE_REQUEST_ERROR(x, y) REQUEST_ERROR_##x = y,
-#include "components/cronet/android/chromium_url_request_error_list.h"
-#undef DEFINE_REQUEST_ERROR
+  REQUEST_ERROR_SUCCESS = 1,
+  REQUEST_ERROR_UNKNOWN = 1,
+  REQUEST_ERROR_MALFORMED_URL = 2,
+  REQUEST_ERROR_CONNECTION_TIMED_OUT = 3,
+  REQUEST_ERROR_UNKNOWN_HOST = 4,
 };
 
 bool ChromiumUrlRequestRegisterJni(JNIEnv* env);
 
 }  // namespace cronet
 
 #endif  // COMPONENTS_CRONET_ANDROID_CHROMIUM_URL_REQUEST_H_