Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 659433002: DevTools: Fix unsaved committed changes UI to match saved state when saving with file manager. (Closed)

Created:
6 years, 2 months ago by vsevik
Modified:
6 years, 2 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Fix unsaved committed changes UI to match saved state when saving with file manager. BUG=167285 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M Source/devtools/front_end/sources/UISourceCodeFrame.js View 2 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/workspace/UISourceCode.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
vsevik
PTAL
6 years, 2 months ago (2014-10-14 05:40:49 UTC) #2
lushnikov
lgtm
6 years, 2 months ago (2014-10-15 08:46:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659433002/1
6 years, 2 months ago (2014-10-15 09:02:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31868)
6 years, 2 months ago (2014-10-15 10:49:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659433002/1
6 years, 2 months ago (2014-10-15 10:54:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31882)
6 years, 2 months ago (2014-10-15 12:58:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659433002/1
6 years, 2 months ago (2014-10-15 13:41:18 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 14:13:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183751

Powered by Google App Engine
This is Rietveld 408576698