Issue 65943002: Add a basic Mojo app that initializes V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 65943002: Add a basic Mojo app that initializes V8 (Closed)

Created:
7 years, 1 month ago by abarth-chromium

Modified:
7 years, 1 month ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium, slightlyoff

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a basic Mojo app that initializes V8 This CL introduces a basic Mojo app that initializes V8 and then exits. Eventually, this app will grow towards being able to execute JavaScript retrieved from the network and letting that JavaScript access Mojo services. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233882

Patch Set 1 #

Patch Set 2 : Remove base dependency #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -4 lines)			Patch
A +	mojo/apps/js/DEPS	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
A	mojo/apps/js/main.cc	View		1 chunk	+24 lines, -0 lines	0 comments	Download
A +	mojo/apps/js/v8_environment.h	View		1 chunk	+7 lines, -3 lines	0 comments	Download
A	mojo/apps/js/v8_environment.cc	View	1	1 chunk	+49 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Darin suggested that I try to avoid depending on base, so I've updated this CL ...

7 years, 1 month ago (2013-11-08 01:10:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/65943002/70001

7 years, 1 month ago (2013-11-08 01:22:29 UTC) #4

Message was sent while issue was closed.

Change committed as 233882

Expand Messages | Collapse Messages