chrome/browser/cocoa/install_from_dmg.mm - Issue 6594096: Clean up CF To NS Casts and make them slightly safer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/install_from_dmg.mm

Issue 6594096: Clean up CF To NS Casts and make them slightly safer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix space Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/install_from_dmg.mm

diff --git a/chrome/browser/cocoa/install_from_dmg.mm b/chrome/browser/cocoa/install_from_dmg.mm

index 8af44f3d4f87e78f542619cd7adf1c206c23ffd7..1c56927a40a1e6a93159eb78f53a34eefd26a13a 100644

--- a/chrome/browser/cocoa/install_from_dmg.mm

+++ b/chrome/browser/cocoa/install_from_dmg.mm

@@ -239,7 +239,7 @@ AuthorizationRef MaybeShowAuthorizationDialog(NSString* application_directory) {

IDS_INSTALL_FROM_DMG_AUTHENTICATION_PROMPT,

l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));

return authorization_util::AuthorizationCreateToRunAsRoot(

- reinterpret_cast<CFStringRef>(prompt));

+ base::mac::NSToCFCast(prompt));

}

// Invokes the installer program at installer_path to copy source_path to

@@ -339,7 +339,7 @@ bool LaunchInstalledApp(NSString* app_path) {

struct LSApplicationParameters parameters = {0};

parameters.flags = kLSLaunchDefaults;

parameters.application = &app_fsref;

- parameters.argv = reinterpret_cast<CFArrayRef>(arguments);

+ parameters.argv = base::mac::NSToCFCast(arguments);

err = LSOpenApplication(&parameters, NULL);

if (err != noErr) {

« no previous file with comments | « chrome/app/chrome_main.cc ('k') | chrome/browser/cocoa/keystone_glue.mm » ('j') | no next file with comments »