Source/devtools/front_end/timeline/TimelinePanel.js - Issue 659403006: DevTools: do not consider ? a shortcut while editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 659403006: DevTools: do not consider ? a shortcut while editing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/main/Main.js ('K') | « Source/devtools/front_end/sources/WorkspaceMappingTip.js ('k') | Source/devtools/front_end/ui/ShortcutRegistry.js » ('j') | Source/devtools/front_end/ui/UIUtils.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js

index e1f73156d635d71781803bac4dcc6518ebc54367..2accd5a40a15643bc845c6f624a4ccf26cfa2b0c 100644

--- a/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -341,7 +341,7 @@ WebInspector.TimelinePanel.prototype = {

if (Runtime.experiments.isEnabled("timelineOnTraceEvents")) {

this._flameChartToggleButton = new WebInspector.StatusBarButton(WebInspector.UIString("Flame chart view. (Use WASD or time selection to navigate)"), "timeline-flame-chart-status-bar-item");

this._flameChartToggleButton.toggled = this._flameChartEnabledSetting.get();

- this._flameChartToggleButton.addEventListener("click", this._flameChartEnabledChanged.bind(this, this._flameChartToggleButton));

+ this._flameChartToggleButton.addEventListener("click", this._flameChartEnabledChanged.bind(this));

this._statusBarButtons.push(this._flameChartToggleButton);

panelStatusBarElement.appendChild(this._flameChartToggleButton.element);

}