Issue 6594001: entd: Factor out syslog_logger code and start using it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6594001: entd: Factor out syslog_logger code and start using it (Closed)

Created:
9 years, 10 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
rginda

CC:
chromium-os-reviews_chromium.org, rginda, gauravsh

Base URL:
ssh://git@gitrw.chromium.org:9222/entd.git@master

Visibility:
Public.

Description

entd: Factor out syslog_logger code and start using it Change-Id: I4a136cbe89605460e4c355c7a2009c3cef704af8 BUG=none TEST=Fire up entd and verify it logs to /var/log/messages Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f92542b

Patch Set 1 #

Patch Set 2 : updated interface #

Patch Set 3 : respond to rginda #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -58 lines)			Patch
	M	main.cc	View	1 2	3 chunks	+4 lines, -58 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rginda

9 years, 9 months ago (2011-03-02 19:26:38 UTC) #2

lgtm with one nit

http://codereview.chromium.org/6594001/diff/4002/main.cc
File main.cc (right):

http://codereview.chromium.org/6594001/diff/4002/main.cc#newcode83
main.cc:83: chromeos::InitLog(log_flags);
nit: newline before this please.

Expand Messages | Collapse Messages