Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659363002: More details printed for Map, DescriptorArray and TransitionArray. (Closed)

Created:
6 years, 2 months ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

More details printed for Map, DescriptorArray and TransitionArray. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24837

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Patch Set 3 : gdbinit updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -59 lines) Patch
M src/objects.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-printer.cc View 1 4 chunks +58 lines, -56 lines 0 comments Download
M src/property.cc View 1 chunk +35 lines, -1 line 0 comments Download
M src/property-details.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/transitions.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/transitions-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gdbinit View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Igor Sheludko
PTAL
6 years, 2 months ago (2014-10-20 08:19:36 UTC) #1
Igor Sheludko
PTAL
6 years, 1 month ago (2014-10-23 09:08:34 UTC) #3
Toon Verwaest
lgtm with single comment https://codereview.chromium.org/659363002/diff/1/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/659363002/diff/1/src/objects-printer.cc#newcode441 src/objects-printer.cc:441: } This is a bit ...
6 years, 1 month ago (2014-10-23 09:54:52 UTC) #4
Igor Sheludko
https://codereview.chromium.org/659363002/diff/1/src/objects-printer.cc File src/objects-printer.cc (right): https://codereview.chromium.org/659363002/diff/1/src/objects-printer.cc#newcode441 src/objects-printer.cc:441: } On 2014/10/23 09:54:51, Toon Verwaest wrote: > This ...
6 years, 1 month ago (2014-10-23 11:21:27 UTC) #7
Igor Sheludko
6 years, 1 month ago (2014-10-23 11:31:49 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:70001) manually as 24837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698