Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 659333004: Added several new bypass telemetry tests for the data reduction proxy (Closed)

Created:
6 years, 2 months ago by sclittle
Modified:
6 years, 2 months ago
Reviewers:
bengr, bolian
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Added several new bypass telemetry tests for the data reduction proxy New tests: - Added new ChromeProxyExplicitBypass integration tests that test "bypass=0", "bypass=<X>", "block=0", and "block=<X>" Chrome-Proxy directives using the test server - Added new ChromeProxyFallback integration test that gets a "bypass=0" directive from the real data reduction proxy Cleanup: - Rewrote the VerifyBadProxies logic, adding support for per-proxy retry times - Also changed VerifyBadProxies to raise an exception instead of returning false when the actual and expected bad proxy lists were different, which was causing all the existing bypass tests to pass in cases when they should have failed - Fixed typo in ChromeProxyCorsBypass test, it passes now - Some general python style cleanup BUG=374397 Committed: https://crrev.com/f95e460c500507a94f3d20c38bdfd80b254c4d36 Cr-Commit-Position: refs/heads/master@{#300295}

Patch Set 1 #

Patch Set 2 : Fixed indentation in VerifyAllProxiesBypassed #

Total comments: 4

Patch Set 3 : Addressed comments #

Patch Set 4 : Synced repo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -43 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py View 1 2 3 3 chunks +19 lines, -0 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 1 2 5 chunks +57 lines, -4 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 7 chunks +90 lines, -30 lines 0 comments Download
A tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/explicit_bypass.py View 1 2 1 chunk +82 lines, -0 lines 0 comments Download
A + tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/fallback.py View 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
sclittle
bolian, bengr: all With this CL and https://codereview.chromium.org/667463003/, all integration tests (except for the block-once ...
6 years, 2 months ago (2014-10-17 22:08:38 UTC) #2
bengr
On 2014/10/17 22:08:38, sclittle wrote: > bolian, bengr: all > > With this CL and ...
6 years, 2 months ago (2014-10-17 22:43:34 UTC) #3
sclittle
On 2014/10/17 22:43:34, bengr1 wrote: > On 2014/10/17 22:08:38, sclittle wrote: > > bolian, bengr: ...
6 years, 2 months ago (2014-10-17 23:01:37 UTC) #4
bengr
lgtm, with nits https://codereview.chromium.org/659333004/diff/20001/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right): https://codereview.chromium.org/659333004/diff/20001/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py#newcode116 tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:116: """Correctness measurement for bypass responses.""" Can ...
6 years, 2 months ago (2014-10-17 23:24:07 UTC) #5
sclittle
https://codereview.chromium.org/659333004/diff/20001/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py File tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py (right): https://codereview.chromium.org/659333004/diff/20001/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py#newcode116 tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py:116: """Correctness measurement for bypass responses.""" On 2014/10/17 23:24:07, bengr1 ...
6 years, 2 months ago (2014-10-17 23:42:33 UTC) #6
bolian
lgtm
6 years, 2 months ago (2014-10-20 06:02:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659333004/40001
6 years, 2 months ago (2014-10-20 06:05:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/80924) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/70564) android_aosp ...
6 years, 2 months ago (2014-10-20 06:09:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659333004/60001
6 years, 2 months ago (2014-10-20 17:18:04 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 2 months ago (2014-10-20 17:49:46 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:50:24 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f95e460c500507a94f3d20c38bdfd80b254c4d36
Cr-Commit-Position: refs/heads/master@{#300295}

Powered by Google App Engine
This is Rietveld 408576698