Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 659333003: Record histograms for on-demand update check results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 72b0586ce582bce6fc42fe9b0bf135e45b6f98c7..4f4828ab89233cf54dab6893487936144b2c4139 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -36219,6 +36219,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="UpdateCheckWin.ErrorHresult">
grt (UTC plus 2) 2014/10/17 18:56:48 should i specify units or type or anything here?
Alexei Svitkine (slow) 2014/10/17 19:00:55 No, though you could make an enum for hresult valu
grt (UTC plus 2) 2014/10/18 02:37:35 Numeric codes are good for now since the potential
+ <owner>grt@chromium.org</owner>
+ <summary>The HRESULT for a failed on-demand update check.</summary>
+</histogram>
+
+<histogram name="UpdateCheckWin.UpdateErrorCode" enum="GoogleUpdateErrorCode">
+ <owner>grt@chromium.org</owner>
+ <summary>The error code for a failed on-demand update check.</summary>
+</histogram>
+
+<histogram name="UpdateCheckWin.UpgradeResult" enum="GoogleUpdateUpgradeResult">
+ <owner>grt@chromium.org</owner>
+ <summary>The result of an on-demand update check.</summary>
+</histogram>
+
<histogram name="UpdateEngine.Attempt.ConnectionType"
enum="UpdateEngineConnectionType">
<owner>zeuthen@chromium.org</owner>
@@ -44621,6 +44636,28 @@ Therefore, the affected-histogram name has to have at least one dot in it.
<int value="13" label="WEB_LOGIN_REQUIRED"/>
</enum>
+<enum name="GoogleUpdateErrorCode" type="int">
+ <int value="0" label="GOOGLE_UPDATE_NO_ERROR"/>
+ <int value="1" label="CANNOT_UPGRADE_CHROME_IN_THIS_DIRECTORY"/>
+ <int value="2" label="GOOGLE_UPDATE_JOB_SERVER_CREATION_FAILED"/>
+ <int value="3" label="GOOGLE_UPDATE_ONDEMAND_CLASS_NOT_FOUND"/>
+ <int value="4" label="GOOGLE_UPDATE_ONDEMAND_CLASS_REPORTED_ERROR"/>
+ <int value="5" label="GOOGLE_UPDATE_GET_RESULT_CALL_FAILED"/>
+ <int value="6" label="GOOGLE_UPDATE_GET_VERSION_INFO_FAILED"/>
+ <int value="7" label="GOOGLE_UPDATE_ERROR_UPDATING"/>
+ <int value="8" label="GOOGLE_UPDATE_DISABLED_BY_POLICY"/>
+ <int value="9" label="GOOGLE_UPDATE_DISABLED_BY_POLICY_AUTO_ONLY"/>
+</enum>
+
+<enum name="GoogleUpdateUpgradeResult" type="int">
+ <int value="0" label="UPGRADE_STARTED"/>
+ <int value="1" label="UPGRADE_CHECK_STARTED"/>
+ <int value="2" label="UPGRADE_IS_AVAILABLE"/>
+ <int value="3" label="UPGRADE_SUCCESSFUL"/>
+ <int value="4" label="UPGRADE_ALREADY_UP_TO_DATE"/>
+ <int value="5" label="UPGRADE_ERROR"/>
+</enum>
+
<enum name="HIDContinueScenarioType" type="int">
<summary>Possible detected devices combination on leaving dialog</summary>
<int value="0" label="Pointing device only detected."/>

Powered by Google App Engine
This is Rietveld 408576698