tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 72b0586ce582bce6fc42fe9b0bf135e45b6f98c7..4f4828ab89233cf54dab6893487936144b2c4139 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -36219,6 +36219,21 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="UpdateCheckWin.ErrorHresult">

[grt (UTC plus 2), 2014/10/17 18:56:48]

should i specify units or type or anything here?

[Alexei Svitkine (slow), 2014/10/17 19:00:55]

No, though you could make an enum for hresult values if there isn't one already.
If not, you'll just see the numeric codes, which might be OK for your use.

[grt (UTC plus 2), 2014/10/18 02:37:35]

Numeric codes are good for now since the potential space for HRESULTs is large.
After collecting some data, perhaps it will make sense to make an enum with
pretty names for the popular values.  Thanks.

+  <owner>grt@chromium.org</owner>
+  <summary>The HRESULT for a failed on-demand update check.</summary>
+</histogram>
+
+<histogram name="UpdateCheckWin.UpdateErrorCode" enum="GoogleUpdateErrorCode">
+  <owner>grt@chromium.org</owner>
+  <summary>The error code for a failed on-demand update check.</summary>
+</histogram>
+
+<histogram name="UpdateCheckWin.UpgradeResult" enum="GoogleUpdateUpgradeResult">
+  <owner>grt@chromium.org</owner>
+  <summary>The result of an on-demand update check.</summary>
+</histogram>
+
 <histogram name="UpdateEngine.Attempt.ConnectionType"
     enum="UpdateEngineConnectionType">
   <owner>zeuthen@chromium.org</owner>
@@ -44621,6 +44636,28 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="13" label="WEB_LOGIN_REQUIRED"/>
 </enum>
 
+<enum name="GoogleUpdateErrorCode" type="int">
+  <int value="0" label="GOOGLE_UPDATE_NO_ERROR"/>
+  <int value="1" label="CANNOT_UPGRADE_CHROME_IN_THIS_DIRECTORY"/>
+  <int value="2" label="GOOGLE_UPDATE_JOB_SERVER_CREATION_FAILED"/>
+  <int value="3" label="GOOGLE_UPDATE_ONDEMAND_CLASS_NOT_FOUND"/>
+  <int value="4" label="GOOGLE_UPDATE_ONDEMAND_CLASS_REPORTED_ERROR"/>
+  <int value="5" label="GOOGLE_UPDATE_GET_RESULT_CALL_FAILED"/>
+  <int value="6" label="GOOGLE_UPDATE_GET_VERSION_INFO_FAILED"/>
+  <int value="7" label="GOOGLE_UPDATE_ERROR_UPDATING"/>
+  <int value="8" label="GOOGLE_UPDATE_DISABLED_BY_POLICY"/>
+  <int value="9" label="GOOGLE_UPDATE_DISABLED_BY_POLICY_AUTO_ONLY"/>
+</enum>
+
+<enum name="GoogleUpdateUpgradeResult" type="int">
+  <int value="0" label="UPGRADE_STARTED"/>
+  <int value="1" label="UPGRADE_CHECK_STARTED"/>
+  <int value="2" label="UPGRADE_IS_AVAILABLE"/>
+  <int value="3" label="UPGRADE_SUCCESSFUL"/>
+  <int value="4" label="UPGRADE_ALREADY_UP_TO_DATE"/>
+  <int value="5" label="UPGRADE_ERROR"/>
+</enum>
+
 <enum name="HIDContinueScenarioType" type="int">
   <summary>Possible detected devices combination on leaving dialog</summary>
   <int value="0" label="Pointing device only detected."/>