Record histograms for on-demand update check results.

chrome/browser/google/google_update_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_update_win.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/message_loop/message_loop.h"
+#include "base/metrics/histogram.h"
+#include "base/metrics/sparse_histogram.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/threading/thread.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/windows_version.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "chrome/installer/util/helper.h"
@@ skipping 361 matching lines @@
   job_holder = NULL;
   on_demand = NULL;
 }
 
 void GoogleUpdate::ReportResults(GoogleUpdateUpgradeResult results,
                                  GoogleUpdateErrorCode error_code,
                                  const base::string16& error_message) {
   // If there is an error, then error code must not be blank, and vice versa.
   DCHECK(results == UPGRADE_ERROR ? error_code != GOOGLE_UPDATE_NO_ERROR :
                                     error_code == GOOGLE_UPDATE_NO_ERROR);
+  UMA_HISTOGRAM_ENUMERATION(
+      "UpdateCheckWin.UpgradeResult", results, NUM_UPGRADE_RESULTS);

[Alexei Svitkine (slow), 2014/10/17 19:00:55]

Can you use the existing GoogleUpdate. prefix instead of introducing a new one
top-level one?

[grt (UTC plus 2), 2014/10/18 02:37:34]

Done.

+  if (results == UPGRADE_ERROR) {
+    UMA_HISTOGRAM_ENUMERATION(
+        "UpdateCheckWin.UpdateErrorCode", error_code, NUM_ERROR_CODES);
+  }
   if (listener_) {
     listener_->OnReportResults(
         results, error_code, error_message, version_available_);
   }
 }
 
 bool GoogleUpdate::ReportFailure(HRESULT hr,
                                  GoogleUpdateErrorCode error_code,
                                  const base::string16& error_message,
                                  base::MessageLoop* main_loop) {
   DLOG(ERROR) << "Communication with Google Update failed: " << hr
               << " error: " << error_code
               << ", message: " << error_message.c_str();
+  UMA_HISTOGRAM_SPARSE_SLOWLY("UpdateCheckWin.ErrorHresult", hr);
   main_loop->PostTask(
       FROM_HERE,
       base::Bind(&GoogleUpdate::ReportResults, this,
                  UPGRADE_ERROR, error_code, error_message));
   return false;
 }