Issue 659313006: mojo: Fix c++ bindings so serialization of empty arrays doesn't crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 659313006: mojo: Fix c++ bindings so serialization of empty arrays doesn't crash. (Closed)

Created:
6 years, 2 months ago by Elliot Glaysher

Modified:
6 years, 2 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

mojo: Fix c++ bindings so serialization of empty arrays doesn't crash. BUG=none Committed: https://crrev.com/c9f03f14314280243387ab3ae5e9d39302ac4fd8 Cr-Commit-Position: refs/heads/master@{#300146}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -2 lines)			Patch
	M	mojo/public/cpp/bindings/lib/array_serialization.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	mojo/public/cpp/bindings/tests/array_unittest.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659313006/1

6 years, 2 months ago (2014-10-17 19:01:46 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 19:45:21 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c9f03f14314280243387ab3ae5e9d39302ac4fd8
Cr-Commit-Position: refs/heads/master@{#300146}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages