Issue 6592089: Adding sniffing of MHTML files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6592089: Adding sniffing of MHTML files. (Closed)

Created:
9 years, 9 months ago by Jay Civelli

Modified:
4 years, 2 months ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Adding sniffing of MHTML files. In order to support opening MHTML files, we need to sniff for them. Since they have a header that might be fairly long before they can be identified with certainty, we have to rely on the file extension. At this point WebKit does not support MHTML, so Chrome only displays it as plain/text (as it does without this CL). BUG=30863 TEST=Run the unit-tests.

Patch Set 1 #

Patch Set 2 : Adding unit-tests #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -8 lines)			Patch
	M	net/base/mime_sniffer.cc	View		2 chunks	+11 lines, -8 lines	0 comments	Download
	M	net/base/mime_sniffer_unittest.cc	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download