Issue 6592057: Be more flexible about PCI lib path: try both libpci.so.3 and libpci.so. So ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6592057: Be more flexible about PCI lib path: try both libpci.so.3 and libpci.so. So ... (Closed)

Created:
9 years, 9 months ago by Zhenyao Mo

Modified:
9 years, 7 months ago

Reviewers:
zmo, Ken Russell (switch to Gerrit)

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Be more flexible about PCI lib path: try both libpci.so.3 and libpci.so. So far mostly we see if libpci.so.3, but today we received someone reporting libpci.so. BUG=58215 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76384

Patch Set 1 #

Total comments: 1

Patch Set 2 : For the records #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/gpu/gpu_info_collector_linux.cc	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM with one comment. http://codereview.chromium.org/6592057/diff/1/chrome/gpu/gpu_info_collector_linux.cc File chrome/gpu/gpu_info_collector_linux.cc (right): http://codereview.chromium.org/6592057/diff/1/chrome/gpu/gpu_info_collector_linux.cc#newcode86 chrome/gpu/gpu_info_collector_linux.cc:86: LOG(ERROR) << "Fail to dlopen ...

9 years, 9 months ago (2011-03-01 01:38:42 UTC) #2

zmo

9 years, 9 months ago (2011-03-01 01:44:18 UTC) #3

On 2011/03/01 01:38:42, kbr wrote:
> LGTM with one comment.
> 
>
http://codereview.chromium.org/6592057/diff/1/chrome/gpu/gpu_info_collector_l...
> File chrome/gpu/gpu_info_collector_linux.cc (right):
> 
>
http://codereview.chromium.org/6592057/diff/1/chrome/gpu/gpu_info_collector_l...
> chrome/gpu/gpu_info_collector_linux.cc:86: LOG(ERROR) << "Fail to dlopen " <<
> lib_name;
> Fail -> Failed. Also, reconsider whether to print this as an error given that
we
> are trying multiple names.

Good point.  I'll use INFO here, and put a LOG(ERROR) when all lib paths fail.

Expand Messages | Collapse Messages