Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 659183002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. Cleanup to make future migration to std::move() easier. BUG=423621 Committed: https://crrev.com/74d6a7e12701d17e427bf30ccc48dfeec8a07806 Cr-Commit-Position: refs/heads/master@{#300013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/command_buffer/service/transfer_buffer_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-16 21:57:03 UTC) #2
jbauman
lgtm
6 years, 2 months ago (2014-10-16 22:00:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659183002/1
6 years, 2 months ago (2014-10-16 22:03:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 23:44:09 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 23:45:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74d6a7e12701d17e427bf30ccc48dfeec8a07806
Cr-Commit-Position: refs/heads/master@{#300013}

Powered by Google App Engine
This is Rietveld 408576698