Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 659153003: Add a unit test for viewsource reverse (Closed)

Created:
6 years, 2 months ago by sgurun-gerrit only
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@viewsource
Project:
chromium
Visibility:
Public.

Description

Add a unit test for viewsource reverse writer handler The reverse writer for viewsource had an incorrect assumption about the path component of URL which was causing a duplication of query and fragment parameters. This change is to unit test the fix that went in https://codereview.chromium.org/655023002/ BUG=336846 Committed: https://crrev.com/d8e1571cb9fc788aedca3358e8370616fe5991ca Cr-Commit-Position: refs/heads/master@{#300281}

Patch Set 1 #

Patch Set 2 : add some comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/browser_url_handler_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_url_handler_impl_unittest.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sgurun-gerrit only
On 2014/10/17 15:08:25, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:sky@chromium.org PTAL, thanks!
6 years, 2 months ago (2014-10-17 15:12:02 UTC) #2
sky
LGTM
6 years, 2 months ago (2014-10-20 15:51:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659153003/20001
6 years, 2 months ago (2014-10-20 16:13:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 16:59:30 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:00:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8e1571cb9fc788aedca3358e8370616fe5991ca
Cr-Commit-Position: refs/heads/master@{#300281}

Powered by Google App Engine
This is Rietveld 408576698