Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 659143002: base: Use nullptr instead of NULL and static_cast in discardable memory unit tests. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

base: Use nullptr instead of NULL and static_cast in discardable memory unit tests. BUG=422953 TEST=base_unittests --gtest_filter=DiscardableMemoryTests* TBR=danakj@chromium.org Committed: https://crrev.com/d8ee1714ece7a563f981813381610fd37c37444e Cr-Commit-Position: refs/heads/master@{#299991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/memory/discardable_memory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
reveman
6 years, 2 months ago (2014-10-16 20:46:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659143002/1
6 years, 2 months ago (2014-10-16 20:48:07 UTC) #4
danakj
LGTM
6 years, 2 months ago (2014-10-16 20:51:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 22:20:29 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d8ee1714ece7a563f981813381610fd37c37444e Cr-Commit-Position: refs/heads/master@{#299991}
6 years, 2 months ago (2014-10-16 22:21:20 UTC) #7
Avi (use Gerrit)
6 years, 2 months ago (2014-10-17 19:41:00 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698