Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: athena/content/web_activity.cc

Issue 659113002: Fix window.close() in Athena (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/content/web_activity.cc
diff --git a/athena/content/web_activity.cc b/athena/content/web_activity.cc
index 6f3f31c510d33dfa6b584b99db28236c14321cf8..73b72ec050b9c19f08c532995769df85ced0e982 100644
--- a/athena/content/web_activity.cc
+++ b/athena/content/web_activity.cc
@@ -370,6 +370,10 @@ class AthenaWebView : public views::WebView {
return athena::OpenFileChooser(web_contents, params);
}
+ virtual void CloseContents(content::WebContents* contents) override {
+ GetWidget()->Close();
oshima 2014/10/16 18:44:48 This may not delete activity. Does the following w
yoshiki 2014/10/16 18:49:58 I'll check whether it works. BTW, should we change
+ }
+
private:
void CreateProgressBar() {
CHECK(!progress_bar_);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698