Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 659113002: Fix window.close() in Athena (Closed)

Created:
6 years, 2 months ago by yoshiki
Modified:
6 years, 2 months ago
Reviewers:
*oshima
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix window.close() in Athena This patch makes AthenaWebView handle content::WebContentsDelegate::CloseContents(). BUG=412188 TEST=manual test Committed: https://crrev.com/a56e093236d97e1378ba5b1849cb15c0b67b8ac2 Cr-Commit-Position: refs/heads/master@{#300125}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use Activity::Delete() #

Patch Set 3 : Pass the activity object instead of finding from the activity manager. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M athena/content/web_activity.cc View 1 2 9 chunks +23 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
yoshiki
Oshima-san, PTAL. Thanks.
6 years, 2 months ago (2014-10-16 18:42:29 UTC) #3
oshima
https://codereview.chromium.org/659113002/diff/1/athena/content/web_activity.cc File athena/content/web_activity.cc (right): https://codereview.chromium.org/659113002/diff/1/athena/content/web_activity.cc#newcode374 athena/content/web_activity.cc:374: GetWidget()->Close(); This may not delete activity. Does the following ...
6 years, 2 months ago (2014-10-16 18:44:48 UTC) #4
yoshiki
https://codereview.chromium.org/659113002/diff/1/athena/content/web_activity.cc File athena/content/web_activity.cc (right): https://codereview.chromium.org/659113002/diff/1/athena/content/web_activity.cc#newcode374 athena/content/web_activity.cc:374: GetWidget()->Close(); On 2014/10/16 18:44:48, oshima wrote: > This may ...
6 years, 2 months ago (2014-10-16 18:49:58 UTC) #5
oshima
On 2014/10/16 18:49:58, yoshiki wrote: > https://codereview.chromium.org/659113002/diff/1/athena/content/web_activity.cc > File athena/content/web_activity.cc (right): > > https://codereview.chromium.org/659113002/diff/1/athena/content/web_activity.cc#newcode374 > ...
6 years, 2 months ago (2014-10-16 18:51:49 UTC) #6
yoshiki
Oshima san, PTAL. Thanks.
6 years, 2 months ago (2014-10-16 23:20:23 UTC) #7
oshima
lgtm
6 years, 2 months ago (2014-10-17 16:41:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659113002/40001
6 years, 2 months ago (2014-10-17 17:21:57 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-17 17:45:09 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 17:45:53 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a56e093236d97e1378ba5b1849cb15c0b67b8ac2
Cr-Commit-Position: refs/heads/master@{#300125}

Powered by Google App Engine
This is Rietveld 408576698