Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6143)

Unified Diff: chrome/browser/tabs/tab_strip_model.cc

Issue 6591097: Changes semantics of TabSelectedAt. For multi-selection the TabStrip (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Convert to a new method Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tabs/tab_strip_model_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tabs/tab_strip_model.cc
diff --git a/chrome/browser/tabs/tab_strip_model.cc b/chrome/browser/tabs/tab_strip_model.cc
index 896f0308410072d84dec9b7c6cc8cfed44dd33a9..a7ff8f66b2ca7f333f86630999b256adf6a61381 100644
--- a/chrome/browser/tabs/tab_strip_model.cc
+++ b/chrome/browser/tabs/tab_strip_model.cc
@@ -183,8 +183,7 @@ TabContentsWrapper* TabStripModel::ReplaceTabContentsAt(
// selected contents as selection changing.
if (selected_index_ == index) {
FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
- TabSelectedAt(old_contents, new_contents,
- selected_index_, false));
+ TabSelectionChanged(this, old_contents, false));
}
return old_contents;
}
@@ -963,16 +962,10 @@ void TabStripModel::ChangeSelectedContentsFrom(
}
selected_index_ = to_index;
- ObserverListBase<TabStripModelObserver>::Iterator it(observers_);
- TabStripModelObserver* obs;
- while ((obs = it.GetNext()) != NULL)
- obs->TabSelectedAt(last_selected_contents, new_contents,
- selected_index_, user_gesture);
- /*
- FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
- TabSelectedAt(last_selected_contents, new_contents, selected_index_,
- user_gesture));
- */
+
+ FOR_EACH_OBSERVER(
+ TabStripModelObserver, observers_,
+ TabSelectionChanged(this, last_selected_contents, user_gesture));
}
void TabStripModel::SelectRelativeTab(bool next) {
« no previous file with comments | « no previous file | chrome/browser/tabs/tab_strip_model_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698