Pass the size to the RenderView on creation.

content/renderer/render_view_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 60 matching lines @@
 // root. VS warns when we inherit the WebWidgetClient method implementations
 // from RenderWidget.  It's safe to ignore that warning.
 #pragma warning(disable: 4250)
 #endif
 
 class PepperDeviceTest;
 class SkBitmap;
 struct PP_NetAddress_Private;
 struct FrameMsg_Navigate_Params;
 struct ViewMsg_PostMessage_Params;
+struct ViewMsg_Resize_Params;
 struct ViewMsg_StopFinding_Params;
 
 namespace base {
 class CommandLine;
 }
 
 namespace blink {
 class WebApplicationCacheHost;
 class WebApplicationCacheHostClient;
 class WebDOMMessageEvent;
@@ skipping 80 matching lines @@
                                 int32 main_frame_routing_id,
                                 int32 surface_id,
                                 int64 session_storage_namespace_id,
                                 const base::string16& frame_name,
                                 bool is_renderer_created,
                                 bool swapped_out,
                                 int32 proxy_routing_id,
                                 bool hidden,
                                 bool never_visible,
                                 int32 next_page_id,
-                                const blink::WebScreenInfo& screen_info);
+                                const blink::WebScreenInfo& screen_info,
+                                const ViewMsg_Resize_Params* initial_size);

[piman, 2014/10/29 18:42:57]

I have a preference towards always passing a ViewMsg_Resize_Params (by const
ref), that includes the screen_info. It's more consistent and a bit simpler...
The default values look identical too (between the ViewMsg_Resize_Params on one
hand, and the various classes that hold the resulting values on the other hand).

[mkosiba (inactive), 2014/10/31 14:35:06]

The reason I was trying to pass this by pointer is to make it optional. In the
popup window case we pass null here.

I'll change the popup window case to create a ViewMsg_Resize_Params and set its
screen info since the RenderWidget::OnResize code looks like it should handle
the empty size case fine.

 
   // Used by content_layouttest_support to hook into the creation of
   // RenderViewImpls.
   static void InstallCreateHook(
       RenderViewImpl* (*create_render_view_impl)(RenderViewImplParams*));
 
   // Returns the RenderViewImpl containing the given WebView.
   static RenderViewImpl* FromWebView(blink::WebView* webview);
 
   // Returns the RenderViewImpl for the given routing ID.
@@ skipping 913 matching lines @@
   // use the Observer interface to filter IPC messages and receive frame change
   // notifications.
   // ---------------------------------------------------------------------------
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_