Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 659073005: [Telemetry] Fix flake in testVTuneProfiler. (Closed)

Created:
6 years, 2 months ago by tonyg
Modified:
6 years, 2 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix flake in testVTuneProfiler. Apparently at one point in time the GetCommandLine methods returned no value for a missing process. Now it always returns a value or an exception. So this code should be looking for the exception instead. BUG= Committed: https://crrev.com/2076b911427d5e212f09a2f84042a43717ee8384 Cr-Commit-Position: refs/heads/master@{#300044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tonyg
6 years, 2 months ago (2014-10-16 20:13:43 UTC) #2
dtu
lgtm
6 years, 2 months ago (2014-10-17 01:25:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659073005/1
6 years, 2 months ago (2014-10-17 01:26:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 02:26:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 02:27:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2076b911427d5e212f09a2f84042a43717ee8384
Cr-Commit-Position: refs/heads/master@{#300044}

Powered by Google App Engine
This is Rietveld 408576698